upgrade.php should check database connection

[slam]

In upgrade.php we should have check for database connection similar to the one we do in /install/functions.php:

            // we should be connected to the db at this stage
            $dbconn = pnDBGetConn(true);
            if (!$dbconn) {
                $action = 'dbinformation';
                $smarty->assign('dbconnectfailed', true);
                $smarty->assign(array('dbhost' => $dbhost, 'dbtype' => $dbtype, 'dbname' => $dbname, 'dbusername' => $dbusername,
                                'dbpassword' => $dbpassword, 'dbtableprefix' => $dbprefix));
            }
            break;

This will avoid not easy to debug errors like this one:

 Allowed memory size of 268435456 bytes exhausted (tried to allocate 21 bytes) in /media/disk1part15/www/includes/pnobjlib/debug.php on line 51

which is in this case not just misleading, but absurd in itself.
Greetings,
Chris

[markwest]

The problem here isn't the db connection itself - this is trapped ok. However when the error is trapped pn_exit is called. This relies on more of the core being available than is used in the upgrade. As a result pn_exit gets call recursively each time generating a backtrace. Hence the running out of memory fairly quickly.

-Mark

[markwest]

(In [24448]) Fixed #30 - upgrade.php should check database connection