core

Ticket #38 (closed Bug: fixed)

Opened 5 months ago

Last modified 5 months ago

Referers collection

Reported by: jami Owned by:
Priority: minor Milestone: 1.0.1
Component: Version: 1.0.0
Keywords: Cc:

Description

i don't investigate too much, but it seems that the admin pager doesn't work correctly (page change, but the displayed list not) and percent-% is always "0"

Change History

Changed 5 months ago by markwest

  • version set to 1.0.0

Changed 5 months ago by markwest

As I don't use this module I don't have any test data for this issue. Could you provide me with an archive of your referrers table? If so please e-mail it to mark at zikula dot org.

Thanks.

-Mark

Changed 5 months ago by jami

well for percent problem,
change line 66 in pnuserapi ( $freq isn't defined)

$items[] = array('url' => $v['url'], 'urls' => $urls, 'freq' => $v['frequency'], 'percent' => round(($freq / $totalfreq * 100), 2));

to

$items[] = array('url' => $v['url'], 'urls' => $urls, 'freq' => $v['frequency'], 'percent' => round(($v['frequency'] / $totalfreq * 100), 2));

and for pager change line 59 in pnadmin to

array('sortby' => $sortby, 'startnum' => $startnum, 'numitems' => $itemsperpage));

cause pnuserapi require 'numitems', plus line 56 in pnuserapi:

$data = DBUtil::selectObjectArray ('referer', '', $sort, $args['startnum-1'], $args['numitems']);

to

$data = DBUtil::selectObjectArray ('referer', '', $sort, $args['startnum']-1, $args['numitems']);

as $args/['startnum-1'/] could not work

Changed 5 months ago by markwest

  • status changed from new to closed
  • resolution set to fixed

Fixed in revision [24426].

Thanks for providing these fixes.

-Mark

Note: See TracTickets for help on using tickets.